[data] Kafka GMK v2 config adds #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avinashak
requested review from
alexander-jiang,
derek-truong,
hsarabu,
mikals0ft and
ruizh22
avinashak
commented
Jan 8, 2025
| @@ -321,7 +321,7 @@ postgres-openssl = { version = "0.5.0", default-features = false, features = ["r | |||
| pulsar = { version = "6.3.0", default-features = false, features = ["tokio-runtime", "auth-oauth2", "flate2", "lz4", "snap", "zstd"], optional = true } | |||
| rand = { version = "0.8.5", default-features = false, features = ["small_rng"] } | |||
| rand_distr = { version = "0.4.3", default-features = false } | |||
| rdkafka = { version = "0.35.0", default-features = false, features = ["tokio", "libz", "ssl", "zstd"], optional = true } | |||
| rdkafka = { version = "0.36.2", default-features = false, features = ["tokio", "libz", "ssl", "zstd", "sasl", "curl", "zstd-pkg-config"], optional = true } | |||
There was a problem hiding this comment.
0.37 of rdkafka has breaking changes so 36.2 is the highest we can go to with simpler upgrades
|
I approve of this commit |
alexander-jiang
approved these changes
Jan 9, 2025
|
yes this was powering the vector x gmk kafka tests in staging i was doing. will also test "in aggregate" after we merge this and your changes before we move forward you can see the |
mikals0ft
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note,
zstdcompression is still not viable but toggling all the necessary depdendency options for it anyway to avoid this song and dance.