feat(rpc): add *RPCCommands and RPCEvents* #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
TrueXPixells
changed the title
vladfrangu
requested changes
Nov 18, 2022
|
hmm, im sorry i dont know how to fix pascalcase cuz other enums are same my named; i dont know what i do |
Not the name of the enum itself, the property names of the enum (so Ready not READY, etc) |
TrueXPixells
requested review from
vladfrangu
and removed request for
iCrawl,
kyranet and
SpaceEEC
vladfrangu
previously approved these changes
Dec 2, 2022
|
yoo @vladfrangu its been long days ago... please can u merge this PR? i deleting unused repos, please.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
i added more rpc commands and events
Note: after /* */ comments are not including discord rpc docs