Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linked roles formatters #10461

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 5:39pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Sep 4, 2024 5:39pm

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.47%. Comparing base (4374374) to head (3dc3b51).
Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10461      +/-   ##
==========================================
+ Coverage   35.45%   35.47%   +0.01%     
==========================================
  Files         228      228              
  Lines       14319    14323       +4     
  Branches     1254     1255       +1     
==========================================
+ Hits         5077     5081       +4     
  Misses       9198     9198              
  Partials       44       44              
Flag Coverage Δ
builders 91.58% <ø> (ø)
formatters 97.47% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sdanialraza sdanialraza force-pushed the feat/add-linked-roles-formatters branch from 373a13e to c583790 Compare August 26, 2024 14:34
packages/formatters/src/formatters.ts Outdated Show resolved Hide resolved
@almeidx almeidx marked this pull request as ready for review September 4, 2024 17:27
@almeidx almeidx requested a review from a team as a code owner September 4, 2024 17:27
@almeidx almeidx added this to the formatters 0.6.0 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants