-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(PartialGroupDMChannel): add missing properties #10502
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
Yeah it's optional because it can be missing for other channel types, my thinking was it would always be present for GroupDMs, but now that you mention it, looking at other djs structures (ThreadChannel) it accounts for that. So I think I should stick to the library behavior |
8a3bdbb
to
4d51ba4
Compare
e0154a4
to
aceb5b3
Compare
I noticed |
If they are returned, feel free to add them in your PR and update the title/description |
10798f2
to
fa796dd
Compare
Yes, I've tested it. The channel object returned in the interaction payload contains the group dm's id, which is the most you would need for a channel component collector. At least I have not encountered any edge cases where it wouldn't work. As long as you have |
420ca17
to
015d962
Compare
7faf350
to
21dfa0e
Compare
Please describe the changes this PR makes and why it should be merged:
Props Added:
I noticedownerId
,last_message_id
andlast_pin_timestamp
was missing fromPartialGroupDMChannel
. This PR fixes that.While looking at the api documentation alone, it is hard to determine for me if theowner_id
can be missing for Group DM Channel's, but from my testing so far, I found it to be always present. So taking that at face valueStatus and versioning classification: