FEATURE: configurable embeddings #1049
Merged
+2,124
−1,001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xfalcox
reviewed
Jan 8, 2025
xfalcox
reviewed
Jan 9, 2025
romanrizzi
force-pushed
the
data_driven_embeddings
branch
5 times, most recently
from
af71ede to
f2238ed
Compare
romanrizzi
changed the title
xfalcox
reviewed
Jan 13, 2025
xfalcox
reviewed
Jan 13, 2025
romanrizzi
force-pushed
the
data_driven_embeddings
branch
4 times, most recently
from
3f6fe30 to
73586c6
Compare
romanrizzi
force-pushed
the
data_driven_embeddings
branch
from
73586c6 to
d8869b3
Compare
romanrizzi
force-pushed
the
data_driven_embeddings
branch
from
d8869b3 to
49cdf46
Compare
xfalcox
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a way to configure embeddings similar to what we already have for other concepts like LLMs, tools, personas, etc.
It hides many old settings and adds a new one called "ai_embeddings_selected_model". We include a data migration to seed the model using these old settings.
It also removes the
DiscourseClassifierservice.