DEV: Convert to native class syntax (#226)

discourse · Nov 29, 2024 · 872dddd · 872dddd
1 parent 74bcfb8
commit 872dddd
Show file tree

Hide file tree

Showing 4 changed files with 51 additions and 54 deletions.
diff --git a/assets/javascripts/discourse/controllers/admin-plugins-code-review.js b/assets/javascripts/discourse/controllers/admin-plugins-code-review.js
@@ -1,16 +1,16 @@
 import { A } from "@ember/array";
 import Controller from "@ember/controller";
-import EmberObject from "@ember/object";
+import EmberObject, { action } from "@ember/object";
 import { Promise } from "rsvp";
 import { ajax } from "discourse/lib/ajax";
 import { popupAjaxError } from "discourse/lib/ajax-error";
 import discourseComputed from "discourse-common/utils/decorators";
 
 const prefix = "/admin/plugins/code-review";
 
-export default Controller.extend({
-  organizations: null,
-  loading: true,
+export default class AdminPluginsCodeReviewController extends Controller {
+  organizations = null;
+  loading = true;
 
   async loadOrganizations() {
     try {
@@ -33,7 +33,7 @@ export default Controller.extend({
     } finally {
       this.set("loading", false);
     }
-  },
+  }
 
   async loadOrganizationRepos(organization) {
     try {
@@ -65,7 +65,7 @@ export default Controller.extend({
     } finally {
       this.set("loading", false);
     }
-  },
+  }
 
   async hasConfiguredWebhook(orgName, repo) {
     if (repo.receivedWebhookState) {
@@ -78,7 +78,7 @@ export default Controller.extend({
 
     repo.set("receivedWebhookState", true);
     repo.set("hasConfiguredWebhook", response["has_configured_webhook"]);
-  },
+  }
 
   @discourseComputed("loadError")
   configureWebhooksTitle(loadError) {
@@ -87,40 +87,37 @@ export default Controller.extend({
     }
 
     return "code_review.webhooks_load_error";
-  },
-
-  actions: {
-    async configureWebhook(organization, repo) {
-      if (repo.hasConfiguredWebhook === false) {
-        let response = await ajax(
-          `${prefix}/organizations/${organization.name}/repos/${repo.name}/configure-webhook.json`,
-          {
-            type: "POST",
-          }
-        );
-
-        repo.set("hasConfiguredWebhook", response["has_configured_webhook"]);
-      }
-    },
-
-    async configureWebhooks() {
-      for (const organization of this.organizations) {
-        for (const repo of organization.repos) {
-          if (repo.hasConfiguredWebhook === false) {
-            let response = await ajax(
-              `${prefix}/organizations/${organization.name}/repos/${repo.name}/configure-webhook.json`,
-              {
-                type: "POST",
-              }
-            );
-
-            repo.set(
-              "hasConfiguredWebhook",
-              response["has_configured_webhook"]
-            );
-          }
+  }
+
+  @action
+  async configureWebhook(organization, repo) {
+    if (repo.hasConfiguredWebhook === false) {
+      let response = await ajax(
+        `${prefix}/organizations/${organization.name}/repos/${repo.name}/configure-webhook.json`,
+        {
+          type: "POST",
+        }
+      );
+
+      repo.set("hasConfiguredWebhook", response["has_configured_webhook"]);
+    }
+  }
+
+  @action
+  async configureWebhooks() {
+    for (const organization of this.organizations) {
+      for (const repo of organization.repos) {
+        if (repo.hasConfiguredWebhook === false) {
+          let response = await ajax(
+            `${prefix}/organizations/${organization.name}/repos/${repo.name}/configure-webhook.json`,
+            {
+              type: "POST",
+            }
+          );
+
+          repo.set("hasConfiguredWebhook", response["has_configured_webhook"]);
         }
       }
-    },
-  },
-});
+    }
+  }
+}
diff --git a/assets/javascripts/discourse/routes/admin-plugins-code-review.js b/assets/javascripts/discourse/routes/admin-plugins-code-review.js
@@ -1,9 +1,9 @@
 import DiscourseRoute from "discourse/routes/discourse";
 
-export default DiscourseRoute.extend({
-  controllerName: "admin-plugins-code-review",
+export default class AdminPluginsCodeReview extends DiscourseRoute {
+  controllerName = "admin-plugins-code-review";
 
   activate() {
     this.controllerFor(this.controllerName).loadOrganizations();
-  },
-});
+  }
+}
diff --git a/assets/javascripts/discourse/routes/user-activity-approval-given.js b/assets/javascripts/discourse/routes/user-activity-approval-given.js
@@ -1,7 +1,7 @@
 import UserTopicListRoute from "discourse/routes/user-topic-list";
 import I18n from "I18n";
 
-export default UserTopicListRoute.extend({
+export default class UserActivityApprovalGiven extends UserTopicListRoute {
   model() {
     const username = this.modelFor("user").username_lower;
     return this.store
@@ -16,7 +16,7 @@ export default UserTopicListRoute.extend({
         model.set("emptyState", this.emptyState());
         return model;
       });
-  },
+  }
 
   emptyState() {
     const user = this.modelFor("user");
@@ -31,5 +31,5 @@ export default UserTopicListRoute.extend({
     }
     const body = "";
     return { title, body };
-  },
-});
+  }
+}
diff --git a/assets/javascripts/discourse/routes/user-activity-approval-pending.js b/assets/javascripts/discourse/routes/user-activity-approval-pending.js
@@ -1,7 +1,7 @@
 import UserTopicListRoute from "discourse/routes/user-topic-list";
 import I18n from "I18n";
 
-export default UserTopicListRoute.extend({
+export default class UserActivityApprovalPending extends UserTopicListRoute {
   model() {
     const username = this.modelFor("user").username_lower;
     return this.store
@@ -16,7 +16,7 @@ export default UserTopicListRoute.extend({
         model.set("emptyState", this.emptyState());
         return model;
       });
-  },
+  }
 
   emptyState() {
     const user = this.modelFor("user");
@@ -31,5 +31,5 @@ export default UserTopicListRoute.extend({
     }
     const body = "";
     return { title, body };
-  },
-});
+  }
+}