Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDST-382: Handle errors while deleting orphaned embargo #41

Merged
merged 7 commits into from
Aug 5, 2024

Conversation

Prashant-bd
Copy link
Contributor

No description provided.

src/Entity/Embargo.php Outdated Show resolved Hide resolved
src/Entity/Embargo.php Outdated Show resolved Hide resolved
src/Entity/Embargo.php Outdated Show resolved Hide resolved
src/Entity/Embargo.php Outdated Show resolved Hide resolved
@adam-vessey
Copy link
Contributor

Just to drop the breadcrumbs: Given probing in #42, resulting in the deprecation: https://github.com/discoverygarden/embargo/actions/runs/10167131862/job/28118809195#step:4:1197

     1x: The Drupal\Tests\field\Traits\EntityReferenceTestTrait is deprecated in drupal:10.2.0 and is removed from drupal:11.0.0. Instead, use \Drupal\Tests\field\Traits\EntityReferenceFieldCreationTrait. See https://www.drupal.org/node/3401941
      1x in ClassLoader::loadClass from Composer\Autoload

I'm pretty sure tests should be fixed between:

@nchiasson-dgi nchiasson-dgi added the patch Backwards compatible bug fixes. label Aug 5, 2024
@nchiasson-dgi nchiasson-dgi merged commit a481d32 into discoverygarden:main Aug 5, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants