Skip to content

Commit

Permalink
modified readme
Browse files Browse the repository at this point in the history
  • Loading branch information
dishmop committed Oct 13, 2020
1 parent 4cb2eeb commit 01be2a3
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
14 changes: 6 additions & 8 deletions .idea/workspace.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
##Brownie Modifiers Test
## Brownie Modifiers Test
This project shows a bug in the test coverage functionality. When using function modifiers on your solidity code which call functions in a base-class, there is no way to get 100% coverage in the tests.

###Steps to reproduce
### Steps to reproduce
Get the code

git clone https://github.com/dishmop/brownie_modifiers_test.git
Expand All @@ -14,18 +14,20 @@ Install pipenv if you don't already have it
Activate virtual environment

pipenv shell
pipenc install
pipenv install

Run tests with coverage
Run tests with coverage

brownie test -C


Note that not all the functions have 100% coverage. Check out the GUI:
Note that not all the functions have 100% coverage. Check out the GUI:

brownie gui

Note that the only red areas are in the modifier code. Try to change the tests in a way which does give us 100% coverage - I wasn't able to.
Note that the only red areas are in the modifier code. The tests attempt to access both addDocHash and removeDocHash as a securityGenerator role and something that isn't that role.

Try to change the tests in a way which does give us 100% coverage - I wasn't able to.



Expand Down

0 comments on commit 01be2a3

Please sign in to comment.