1600 procedure model issues #1657
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…block double clicking to expand node categories).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues with the
ProcedureModel, enables appending nodes by double clicking (similar to the functionality available for theModulepalette, and also cleans up the slots of theConfigurationTaba tad.This turned out to be an interesting one, that required a deep-dive into the almost non-existent docs. It seems like the issues came down to fact that
dropMimeDataalready results in a call toremoveRowsonQt::MoveAction. So, we were actually trying to remove the rows twice. Also, I think the call tosetData, and thus emittingdataChanged, was troublesome (and now I believe unnecessary) too.Edit: There still seems to be a problem with nodes that have a
branch...Closes #1600.