-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise CIF Import GUI, Molecular Supercell Generation & Configuration Outputs #1679
Conversation
…gated to the output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Overall I think this puts us exactly where we want to be, but I spotted one significant thing during testing, and that is that when generating a supercell of molecules we don't handle the bonding correctly, or at least we aren't storing and using the "reassembled" molecular fragments in the first place:
(This output is from 251754.cif, with a 2,1,1 supercell).
A further small thing is that we default to a framework species on the final output page, but if we know we have molecular species in the system we should default to generating molecular output.
…r species, and grab the box from the Supercell Configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This has highlighted some other things we can do, but I have captured these as separate issues as this PR is already big enough.
… Configuration Outputs (#1679) Co-authored-by: Tristan Youngs <[email protected]>
… Configuration Outputs (#1679) Co-authored-by: Tristan Youngs <[email protected]>
… Configuration Outputs (#1679) Co-authored-by: Tristan Youngs <[email protected]>
This PR fixes/enhances various parts of the CIF import process. In particular:
Species Partitioning
page, replaced with anOutput
page where the partitioning can be performed.Output
page gives a preview of theConfiguration
that will be outputted.Output
page, a supercell can be created, the partitioning of the species can be changed and a configuration can be optionally outputted (for the molecular and framework cases).This definitely needs thorough testing and analysis to ensure that the initial intentions of the code have not been lost!