1709 Enabled Buttons for Modules #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhinoella
requested changes
Nov 29, 2023
Co-authored-by: Noella Spitz <[email protected]>
rhinoella
approved these changes
Nov 30, 2023
|
@rhinoella - Requested a re-review as I missed a couple of bits before! |
rhinoella
approved these changes
Nov 30, 2023
rprospero
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Noella Spitz <[email protected]>
rprospero
pushed a commit
that referenced
this pull request
Apr 8, 2024
Co-authored-by: Noella Spitz <[email protected]>
rprospero
pushed a commit
that referenced
this pull request
Apr 9, 2024
Co-authored-by: Noella Spitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
ModuleLayerModelfromQAbstractListModeltoQAbstractTableModelwith a view to removing the "floating" controls for the enabled/disabled state and frequency of individual modules in the list.Below, the old style is on the left, with this PR moving us to the right (see that we now have the means to clearly indicate the module type as well).
Closes #1709.
Closes #1677 (or at least obfuscates it).