-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1076 enable backward compatibility #1740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprospero
added
8
DIfficulty: 8
TOML
Deals with the conversion of custom file formats into TOML
labels
Nov 30, 2023
trisyoungs
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should do the job nicely. - just have some pedantry regarding naming of things!
Obviously its hard to say how much compatibility fixing we'll have to do as we progress, so we'll see how the storage for backwards upgrade data pans out.
rprospero
added a commit
that referenced
this pull request
Mar 11, 2024
rprospero
added a commit
that referenced
this pull request
Apr 8, 2024
rprospero
added a commit
that referenced
this pull request
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the framework for backward compatibility. This includes some code for upgrading files from version 0.
To ease users who are creating files by hand, including a version is optional. This will cause the program to assume that the file was written for the current version. This will trigger a warning to alert the user. Files saves by Dissolve will always include the version number.
Closes #1076