Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1076 enable backward compatibility #1740

Merged
merged 12 commits into from
Dec 4, 2023

Conversation

rprospero
Copy link
Contributor

This PR adds the framework for backward compatibility. This includes some code for upgrading files from version 0.

To ease users who are creating files by hand, including a version is optional. This will cause the program to assume that the file was written for the current version. This will trigger a warning to alert the user. Files saves by Dissolve will always include the version number.

Closes #1076

@rprospero rprospero added 8 DIfficulty: 8 TOML Deals with the conversion of custom file formats into TOML labels Nov 30, 2023
@rprospero rprospero requested a review from trisyoungs November 30, 2023 14:17
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should do the job nicely. - just have some pedantry regarding naming of things!

Obviously its hard to say how much compatibility fixing we'll have to do as we progress, so we'll see how the storage for backwards upgrade data pans out.

src/main/compatibility.h Show resolved Hide resolved
src/main/compatibility.cpp Outdated Show resolved Hide resolved
src/main/compatibility.cpp Outdated Show resolved Hide resolved
src/main/compatibility.cpp Outdated Show resolved Hide resolved
src/main/io.cpp Outdated Show resolved Hide resolved
src/main/version.h Outdated Show resolved Hide resolved
src/main/io.cpp Outdated Show resolved Hide resolved
@rprospero rprospero merged commit 5b3752a into develop Dec 4, 2023
7 checks passed
@rprospero rprospero deleted the 1076_enable_backward_compatibility branch December 4, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 DIfficulty: 8 TOML Deals with the conversion of custom file formats into TOML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support infinite backwards compatibility in TOML files
2 participants