Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1724 Enable loading of TOML files #1742

Merged
merged 7 commits into from
Dec 6, 2023
Merged

1724 Enable loading of TOML files #1742

merged 7 commits into from
Dec 6, 2023

Conversation

rprospero
Copy link
Contributor

The file loading now goes through four stages:

  1. If the file name ends in ".toml", force the user of the TOML parser and fail if it fails
  2. Check if the file is a restart file and fail with an error telling the user about the problem if it is
  3. Try parsing the file as TOML
  4. Parse using the original parser

Closes #1724

@rprospero rprospero added 4 DIfficulty: 4 TOML Deals with the conversion of custom file formats into TOML labels Dec 1, 2023
@rprospero rprospero requested a review from trisyoungs December 1, 2023 16:46
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. It's a shame that C++ users have to wait until C++20 to get std::string_view::ends_with(), though. Urfff!

@rprospero rprospero merged commit bc5f3df into develop Dec 6, 2023
7 checks passed
@rprospero rprospero deleted the 1724_load_toml_file branch December 6, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 DIfficulty: 4 TOML Deals with the conversion of custom file formats into TOML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rework file loader to support TOML
2 participants