-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qml theme #1895
base: develop
Are you sure you want to change the base?
Qml theme #1895
Conversation
There is one large accessibility concern with adding the custom styling. Certain users will need to be able to pass in their own specific styles to use the software. The good part about our setup is that they can just plug in the style that they use for other Qt applications, it also means that our theme cannot contain custom widgets. That's not to say that we can't use custom widgets, but merely that they can't be namespaced into the theme. For this specific moment, it means that we'll need to rework how Button, ButtonPanel, and SquareButton work together. Button will need to be left in the theme file, but cannot depend on the other two widgets. Meanwhile, ButtonPanel and SquareButton will need to be moved out of the theme directory and into the main directory (or some other widget subdirectory). This also means that we'll need an adapter to get the colours from the theme. I'm suspecting that we'll just be setting the |
@rprospero Agree that accessibility should be a concern of ours. I had envisaged at the outset two colour schemes (dark and light) accessible through a core style object ( |
No description provided.