refactor: Tidy up benchmarks (#1927) #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rprospero
approved these changes
Jun 26, 2024
Comment on lines
+40
to
+44
| static std::map<SpeciesPopulation, int> populationSizes = {{SpeciesPopulation::Single, 1}, | ||
| {SpeciesPopulation::Small, 1000}, | ||
| {SpeciesPopulation::Medium, 5000}, | ||
| {SpeciesPopulation::Large, 10000}}; | ||
| Messenger::setQuiet(true); |
There was a problem hiding this comment.
This is so much more convenient than the old setup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1927 and overhauls our benchmark suite to be more consistent with the rest of the code and easier to maintain in the long run.
Briefly:
Benchmarknamespace (c.f. theUnitTestnamespace)Problemclass has been re-engineered a little to simplify and tidy, and the loading of input files and handling of different system sizes is now cleaner.AngleModulehas been added in anticipation of perf: Combinable histograms for angle module parallel execution #1937Closes #1927.