Code

refactor: Common data table model#1959

Code

Draft

trisyoungs wants to merge 42 commits intodevelopdisorderedmaterials/dissolve:developfrom 1902-data-table-interfacedisorderedmaterials/dissolve:1902-data-table-interfaceCopy head branch name to clipboard

+886-196

Commits

Commits on Jul 9, 2024

• Starting to implement add/remove buttons for variable removal.

  trisyoungs

  committed
  a300304

  Copy full SHA for a300304

• Start sketching out C++-side custom model.

  trisyoungs

  committed
  ac9cb7e

  Copy full SHA for ac9cb7e

• All working so far.

  trisyoungs

  committed
  84f684c

  Copy full SHA for 84f684c

• Move to using std::variant.

  trisyoungs

  committed
  540b341

  Copy full SHA for 540b341

• Simplify table extent determination.

  trisyoungs

  committed
  85c271f

  Copy full SHA for 85c271f

• Error message.

  trisyoungs

  committed
  e17edf4

  Copy full SHA for e17edf4

Commits on Jul 10, 2024

• Move to new files.

  trisyoungs

  committed
  df2310f

  Copy full SHA for df2310f

• Comments.

  trisyoungs

  committed
  7e8e7de

  Copy full SHA for 7e8e7de

• Rename.

  trisyoungs

  committed
  e590227

  Copy full SHA for e590227

• Remove testing code from ExpressionVariableVectorKeyword.

  trisyoungs

  committed
  62311f6

  Copy full SHA for 62311f6

• Begin implementing data mutation links.

  trisyoungs

  committed
  32d9d80

  Copy full SHA for 32d9d80

Commits on Jul 16, 2024

• Tidy up.

  trisyoungs

  committed
  f8541f6

  Copy full SHA for f8541f6

• Insert and append items.

  trisyoungs

  committed
  5701c52

  Copy full SHA for 5701c52

• Fix, tidy.

  trisyoungs

  committed
  0e785f0

  Copy full SHA for 0e785f0

• Fix logic, update selection behaviour.

  trisyoungs

  committed
  bfb5b7e

  Copy full SHA for bfb5b7e

Commits on Jul 17, 2024

• Remove rows.

  trisyoungs

  committed
  ded7b15

  Copy full SHA for ded7b15

• User per-property setters and getters.

  trisyoungs

  committed
  026cd70

  Copy full SHA for 026cd70

• Return flags.

  trisyoungs

  committed
  778b0e5

  Copy full SHA for 778b0e5

Commits on Jul 19, 2024

• Namespace and split up.

  trisyoungs

  committed
  df41e52

  Copy full SHA for df41e52

• Give both base and storage classes to model to try and handle different storage approaches.

  trisyoungs

  committed
  c2cd9ca

  Copy full SHA for c2cd9ca

• Allow setters to be overriden for specific purposes.

  trisyoungs

  committed
  5f4a2d4

  Copy full SHA for 5f4a2d4

• Rename functions for consistency.

  trisyoungs

  committed
  dc7c7d7

  Copy full SHA for dc7c7d7

• Use a static templated function specialisation to provide the properties of the target class.

  trisyoungs

  committed
  83ea61a

  Copy full SHA for 83ea61a

Commits on Jul 20, 2024

• Rename Qt interface for consistency.

  trisyoungs

  committed
  e3b82cf

  Copy full SHA for e3b82cf

• Tidy up base model.

  trisyoungs

  committed
  a6b7222

  Copy full SHA for a6b7222

Commits on Jul 21, 2024

• Sneaky overloading of an item creation function to handle bare vs pointer classes.

  trisyoungs

  committed
  75cbe14

  Copy full SHA for 75cbe14

• Harmonise creation of ExpressionVariables.

  trisyoungs

  committed
  409528a

  Copy full SHA for 409528a

Commits on Jul 22, 2024

• Rename class.

  trisyoungs

  committed
  6d5eff1

  Copy full SHA for 6d5eff1

• Constify some accessors.

  trisyoungs

  committed
  ed839db

  Copy full SHA for ed839db

• Data mutator and signals.

  trisyoungs

  committed
  e41a4db

  Copy full SHA for e41a4db

• More const.

  trisyoungs

  committed
  38de575

  Copy full SHA for 38de575

• Add emplaceAppend function.

  trisyoungs

  committed
  9060e29

  Copy full SHA for 9060e29

• Don't assume the use std::make_shared or std::make_unique since we might be storing base (pure virtual) classes.

  trisyoungs

  committed
  8cc9fee

  Copy full SHA for 8cc9fee

• Fix mutator return function.

  trisyoungs

  committed
  02ef714

  Copy full SHA for 02ef714

Commits on Jul 25, 2024

• Apply suggestions from code review

  Show description for 9aefc63
  

  trisyoungs

  and

  rprospero

  authored
  9aefc63

  Copy full SHA for 9aefc63

• Formatting, remove PropertyVisitor voodoo.

  trisyoungs

  committed
  b3dc1cc

  Copy full SHA for b3dc1cc

• Update src/templates/dataModelItem.h

  Show description for 6da3e42
  

  trisyoungs

  and

  rprospero

  authored
  6da3e42

  Copy full SHA for 6da3e42

• Refactor use of ItemProperty after previous change.

  trisyoungs

  committed
  2491ca5

  Copy full SHA for 2491ca5

• No need to override nProperties().

  trisyoungs

  committed
  eab2c66

  Copy full SHA for eab2c66

• Public access to data vector of VectorMutator, and don't bother with returning a pair..

  trisyoungs

  committed
  97cc62e

  Copy full SHA for 97cc62e

Commits on Jul 29, 2024

• Add lambda-matched removeItem() function.

  trisyoungs

  committed
  a6ba1a3

  Copy full SHA for a6ba1a3

• Register signal fuctions per-object.

  trisyoungs

  committed
  ef02e84

  Copy full SHA for ef02e84