Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust potential range against box geometry dialog #1992

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

aboswel
Copy link

@aboswel aboswel commented Oct 23, 2024

Auto-adjust pair potential range when adding configurations #1206

Before starting a simulation, current configuration box sizes are retrieved, and their inscribed sphere radius calculated, the smallest of which is compared to the Pair Potential Range. If this radius is lower than the range, a dialog is called asking the user if they want the range to be reduced to the highest acceptable value before running the simulation.

@aboswel aboswel linked an issue Oct 23, 2024 that may be closed by this pull request
@aboswel aboswel changed the title Potential range check working, checking before simulation start feat: adjust potential range against box geometry dialog Oct 23, 2024
@aboswel aboswel marked this pull request as draft October 23, 2024 14:27
src/gui/CMakeLists.txt Outdated Show resolved Hide resolved
src/gui/gui_simulation.cpp Outdated Show resolved Hide resolved
src/gui/pairPotentialCheckDialog.cpp Outdated Show resolved Hide resolved
src/gui/pairPotentialCheckDialog.cpp Outdated Show resolved Hide resolved
src/gui/pairPotentialCheckDialog.cpp Outdated Show resolved Hide resolved
src/gui/pairPotentialCheckDialog.cpp Outdated Show resolved Hide resolved
src/gui/pairPotentialCheckDialog.h Outdated Show resolved Hide resolved
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about there. Need to adjust the formatting!

src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.h Outdated Show resolved Hide resolved
src/gui/menu_configuration.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
@aboswel aboswel marked this pull request as ready for review December 9, 2024 14:57
@aboswel aboswel requested a review from trisyoungs December 10, 2024 17:06
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blank line police are out in force today, but this looks good to go otherwise!

src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
src/gui/gui.cpp Outdated Show resolved Hide resolved
aboswel and others added 4 commits December 17, 2024 10:15
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-adjust pair potential range when adding configurations
2 participants