-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust potential range against box geometry dialog #1992
Open
aboswel
wants to merge
12
commits into
develop
Choose a base branch
from
potential-range-check
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboswel
changed the title
Potential range check working, checking before simulation start
feat: adjust potential range against box geometry dialog
Oct 23, 2024
trisyoungs
requested changes
Oct 23, 2024
…nly calling at setupIteration
trisyoungs
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just about there. Need to adjust the formatting!
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
trisyoungs
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blank line police are out in force today, but this looks good to go otherwise!
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Co-authored-by: Tristan Youngs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-adjust pair potential range when adding configurations #1206
Before starting a simulation, current configuration box sizes are retrieved, and their inscribed sphere radius calculated, the smallest of which is compared to the Pair Potential Range. If this radius is lower than the range, a dialog is called asking the user if they want the range to be reduced to the highest acceptable value before running the simulation.