-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node Graph module system #1995
base: develop
Are you sure you want to change the base?
Conversation
That actual nodes are hard coded, but at least it's an array.
It was only ever used in the ExampleGraphModel, as the real models moved to a more stable method
…solve into GraphViewModules
Try and actually encapsulate everything
and correct some documentation on GraphEdgeModel
Is there a reason we aren't using the directory |
@RobBuchananCompPhys Ironically, I originally did have everything in the I'm not opposed to moving the code into the other directory if people find that clearer (as clarity was the entire point of the move in the first place). |
This contains the intial prototype for the Node Graph viewer. Full user support isn't available, but it does provide a very basic infrastructure.
Above is a basic screenshot of an example of the code. The nodes of the generator are currently linked linearly to indicate the order of the events, but it's perfectly posible to have them each connect back to the generator individually.
This most interesting files to examine are
The following changes should be made eventually, but are out of scope of the current PR:
GraphNodeModel
should return an insertion object used to insert new nodes. This could use RAII for better safety, instead of needing to remember to callbeginInsert
andendInsert