Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNet 3+ model added #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

UNet 3+ model added #385

wants to merge 2 commits into from

Conversation

hamidriasat
Copy link

Two changes

  • New model UNet 3+ added
  • Reference also added in README.md

@divamgupta
Copy link
Owner

Hi thanks for the PR, but it seems like that the new model you added might not work with other functionality of the repo. For e.g. it is not added in the all_models.py , hence cli tools wont be able to use it.

@hamidriasat hamidriasat marked this pull request as draft November 5, 2022 18:29
@hamidriasat hamidriasat marked this pull request as ready for review November 6, 2022 13:35
@hamidriasat
Copy link
Author

Hi @divamgupta, thanks for your reply.
New changes have been made in code to make it compatible with rest of the repo functionality. Please test it with cli tools. I hope it works this time, if anything is missing please let me know.

Following changes have been made in the current commit:

  • Unet3+ model reference added in all_models.py
  • Code formatting in unet3_plus.py to make sure local methods are not accessible to outside classes/objects
  • PEP8 code formatting of test_models.py to make sure it's easily readable
  • Unet3+ reference added in test_models method of test_models.py file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants