fix: options.project is mandatory for ui (#7)

divriots · Feb 14, 2022 · fad3623 · fad3623
1 parent a865eb3
commit fad3623
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "vite-plugin-firebase",
-  "version": "0.2.3",
+  "version": "0.2.4",
   "main": "dist/index.js",
   "module": "dist/index.mjs",
   "types": "dist/index.d.ts",

diff --git a/src/index.ts b/src/index.ts
@@ -26,13 +26,14 @@ import { shutdownWhenKilled } from 'firebase-tools/lib/emulator/commandUtils.js'
 
 export interface FirebasePluginOptions {
   projectId: string | ((server: ViteDevServer) => string)
+  projectName: string | ((server: ViteDevServer) => string)
   root?: string
   materializeConfig?: boolean
   targets: string[]
   showUI: boolean
 }
 
-export default function firebasePlugin({projectId, root, materializeConfig, targets = ['hosting', 'functions'], showUI = false}: FirebasePluginOptions) {
+export default function firebasePlugin({projectId, projectName = projectId, root, materializeConfig, targets = ['hosting', 'functions'], showUI = false}: FirebasePluginOptions) {
   return {
     name: "vite:firebase",
     async configureServer(server: ViteDevServer) {
@@ -44,9 +45,11 @@ export default function firebasePlugin({projectId, root, materializeConfig, targ
         shutdownWhenKilled({});
       }
       if (typeof projectId !== 'string') projectId = projectId(server);
+      if (typeof projectName !== 'string') projectName = projectName(server);
       const account = getProjectDefaultAccount(projectDir);
       const options = {
         projectId,
+        project: projectName,
         projectDir,
         nonInteractive: true,
         account,