Develop #143
Merged
Develop #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes functionality for creating the database and necessary table if it doesn't exist, and an interface for adding new words, adding test rows, and printing all rows in the database.
- Add User Dictionary button - Add UserDictionaryViewController that shows (surprise) entries in the user dictionary
Also: - Refactor UserDictionaryViewController to move UITableView methods into extensions - Add temporary title to UserDictionaryViewController
Having the "bolden" function as an extension to String means it's not limited to just the "Strings" class, and can be used more generically.
- All case versions are grouped as a single word in the User Dictionary list - Word context view displays words in their input case
For some reason the built in notifications never get fired. Created our own.
This prevents a crash when typing while full access is not granted.
This was working all along, the problem was just that "i" is already in the speller.
This needs a refactor
This way a dictionary can be initialized with a locale so we don't need to constantly pass in a keyboard locale into each call.
This test ensures that the word is removed only for the given locale.
This reverts commit 5302a37.
allLocales is now in an extension in a separate file that is only accessible to the HostingApp. Now only one type `KeyboardLocale`, removed `KeyboardLocales`.
This allows the user dictionary and tests to work. It seems like someone took the old bundle ID we were using.
Feature/user dictionary #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add User Dictionary #47