Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 648 unable to unlink #649

Merged
merged 19 commits into from
Sep 30, 2023
Merged

Conversation

jrief
Copy link
Collaborator

@jrief jrief commented Sep 20, 2023

This change can be used to reset the context of a plugin to its initial state. It works by evaluating the response code of a submitted plugin. If that is 204 – No Content, that initial text is restored and the plugin is removed. This allows authors of plugins to disconnect them using the already existing plugin editor.

I use it to unlink texts, but many other use cases then are possible as well.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (10de493) 76.18% compared to head (4bf8b38) 76.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
- Coverage   76.18%   76.15%   -0.03%     
==========================================
  Files          20       20              
  Lines         932      931       -1     
  Branches      124      124              
==========================================
- Hits          710      709       -1     
  Misses        196      196              
  Partials       26       26              
Files Changed Coverage Δ
djangocms_text_ckeditor/cms_plugins.py 73.80% <100.00%> (-0.09%) ⬇️
djangocms_text_ckeditor/widgets.py 81.53% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrief Can you add a note in the docs and refer to an example on how to use that feature?

@fsbraun fsbraun merged commit 4e5c4bd into master Sep 30, 2023
103 checks passed
@fsbraun fsbraun mentioned this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants