Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove legacy code from Django pre 1.4 #651

Merged
merged 8 commits into from
Sep 24, 2023
Merged

fix: Remove legacy code from Django pre 1.4 #651

merged 8 commits into from
Sep 24, 2023

Conversation

fsbraun
Copy link
Member

@fsbraun fsbraun commented Sep 22, 2023

This PR is required for Django 5

@fsbraun fsbraun requested a review from marksweb September 22, 2023 16:49
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.18% 🎉

Comparison is base (10de493) 76.18% compared to head (c3d01fd) 76.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #651      +/-   ##
==========================================
+ Coverage   76.18%   76.36%   +0.18%     
==========================================
  Files          20       20              
  Lines         932      918      -14     
  Branches      124      123       -1     
==========================================
- Hits          710      701       -9     
+ Misses        196      191       -5     
  Partials       26       26              
Files Changed Coverage Δ
djangocms_text_ckeditor/utils.py 94.11% <ø> (+4.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@fsbraun fsbraun merged commit 25e28e3 into django-cms:master Sep 24, 2023
54 checks passed
@fsbraun fsbraun mentioned this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants