-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AbstractOrder.return_order #187
Conversation
5203751
to
b1f8672
Compare
c4e1d61
to
468bdf5
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
- Coverage 86.79% 86.73% -0.06%
==========================================
Files 64 64
Lines 2347 2375 +28
==========================================
+ Hits 2037 2060 +23
- Misses 310 315 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, only correct those few changes.
CHANGELOG
Outdated
@@ -1,6 +1,10 @@ | |||
django-plans changelog | |||
====================== | |||
|
|||
1.1.0 (unreleased) | |||
------------------ | |||
* Add `AbstractOrder.return_order` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AbstractOrder.return_order()
to be clear that it is a function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
docs/source/index.rst
Outdated
@@ -47,6 +47,7 @@ Contributors: | |||
* Victor Safronovich <[email protected]> | |||
* Dominik Kozaczko <http://dominik.kozaczko.info> | |||
* Petr Dlouhý <[email protected]> | |||
* Blender Kit <[email protected]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BlenderKit <[email protected]>
and/or give yourself a credit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
@@ -13,6 +13,7 @@ | |||
framework. | |||
|
|||
""" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably unnecessary modification of this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
468bdf5
to
318e260
Compare
Symmetrically to
AbstractOrder.complete_order
, we want to return an order and reduce the account.