Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2to3 #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

2to3 #66

wants to merge 1 commit into from

Conversation

jeroenoldenburger
Copy link

Could you please merge these 2to3 changes

@kavdev
Copy link
Contributor

kavdev commented Aug 10, 2015

What version of python are you running? The package should work with 3.2+ as is.

@jeroenoldenburger
Copy link
Author

I am running python 3.4. I get the following error:

File ".../lib/python3.4/site-packages/djangotoolbox/fields.py", line 274, in _set_model
if model is not None and isinstance(self.embedded_model, basestring):
NameError: name 'basestring' is not defined

Therefore i searched (and found) a fork which ran 2to3.

Maybe python-modernize might result in code which runs in both python 2 and 3

@kavdev
Copy link
Contributor

kavdev commented Aug 11, 2015

Sorry, forgot about the other modules. #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants