Fixed URLRouter root_path handling. #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asedeno
commented
Nov 16, 2022
| root_path = scope.get("root_path", "") | ||
| if root_path and not path.startswith(root_path): | ||
| # If root_path is present, path must start with it. | ||
| raise ValueError("No route found for path %r." % path) |
There was a problem hiding this comment.
This should probably mention root_path as well, but I was not sure how best to phrase it. Suggestions welcome.
|
any news on when this could be merged ? |
|
@tevariou It's on my list to review now. |
Signed-off-by: Alejandro R. Sedeño <[email protected]> Signed-off-by: Alejandro R Sedeño <[email protected]>
If we have a scope["root_path"], raise if it does not prefix scope["path"], and strip it from scope["path"] if it does. Do this only if we're in an outermost URLRouter. Signed-off-by: Alejandro R. Sedeño <[email protected]> Signed-off-by: Alejandro R Sedeño <[email protected]>
carltongibson
force-pushed
the
handle-root-path
branch
from
bbf33a7 to
b7032d7
Compare
carltongibson
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Right, I finally got to it. Thanks @asedeno, and thanks for your patience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in django/daphne#125, this adds handing of
scope["root_path"]tochannels.routing.URLRouter.