Ensure text message exists before handling on WebsocketConsumer
#2097
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @cacosandon, this looks reasonable to me. Can you add a regression test? |
cacosandon
force-pushed
the
fix/hypercorn/websockets-message-handler
branch
from
e8a795e to
26fdd81
Compare
|
Sorry for the super late reaction @bigfootjon, I've added a regression test! Had to use |
cacosandon
force-pushed
the
fix/hypercorn/websockets-message-handler
branch
from
e539976 to
43a83c6
Compare
carltongibson
approved these changes
Sep 4, 2024
|
(Sorry, @cacosandon : can you fix the lint error? Thanks.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
uvicornordaphne, only one oftextorbytesis sent.But on
hypercorn, both of them are sent, but withNonevalue:https://github.com/pgjones/hypercorn/blob/31639ec2f4d03aa920b95c84686163901224c6cf/src/hypercorn/protocol/ws_stream.py#L159
So if you just send
bytes,textwill beNoneand you won't be able to handle the message.I just add an extra check.