Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hard-coded teams #12

Merged
merged 1 commit into from
Aug 29, 2016
Merged

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Aug 24, 2016

An even quicker and dirtier solution is just to keep a whitelist with the members of "Team Phobos".

PR for the quick fix idea by @klickverbot

CC @MartinNowak @schveiguy @burner

I think in the following weeks we should decide whether dlang-bot is worth keeping and then implement it in D, which I would prefer to hack with. However I tested it locally with three PRs and it seems to work :)

I quickly created this whitelist table and I am pretty sure I missed someone (?). In any case with the Heroku auto-deploy this white-list table can even be edited from the web ;-)

Btw this should fix all open issues (#7, #10, #11) for the time being.

"andralex", "DmitryOlshansky", "jmdavis", "rainers", "schveiguy", "CyberShadow"],
"dlang/phobos": ["WalterBright", "MartinNowak", "yebblies", "AndrejMitrovic", "klickverbot", "9rnsr",
"andralex", "DmitryOlshansky", "jmdavis", "rainers", "schveiguy", "9il", "CyberShadow",
"Hackerpilot", "quickfur", "wilzbach"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add my name to it as well

@dnadlinger
Copy link

dnadlinger commented Aug 29, 2016

There is a couple of missing people, but I'm merging this now because the wrong "you've been assigned" messages are getting annoying.

@wilzbach: You should be able to view a list of members for all of the teams here. Of course, not all of them might be active, but erring on the side of being more inclusive might be wise.

@dnadlinger dnadlinger merged commit 6810062 into dlang-bots:master Aug 29, 2016
@dnadlinger
Copy link

Hmm, I guess it makes sense to ignore inactive people, although I wish we could automate that (scrap the commit log once every week or so?).

@wilzbach wilzbach deleted the hard-coded-teams branch August 29, 2016 03:30
@wilzbach
Copy link
Member Author

wilzbach commented Aug 29, 2016

you can add my name to it as well

@burner Sorry lost track of it.- > #14

There is a couple of missing people, but I'm merging this now because the wrong "you've been assigned" messages are getting annoying.

Oh I felt the same. I actually wanted to turn the bot (temporarily) off today.

@wilzbach: You should be able to view a list of members for all of the teams here. Of course, not all of them might be active, but erring on the side of being more inclusive might be wise.

#14 should include a more complete list.
For the tools repo I went through the commits list and looked at merge commits in the last two years.

Hmm, I guess it makes sense to ignore inactive people, although I wish we could automate that (scrap the commit log once every week or so?).

I wish so too, but unfortunately I won't get to that in the next two weeks & it might get tricky, because there are some people that only merge stuff once in a while (e.g. druntime, dlang.org or tools) and thus could be filtered out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants