Skip to content

Commit

Permalink
GitHub Actions: Bump macos-12 jobs to macos-13
Browse files Browse the repository at this point in the history
As the macos-12 image will be 'fully unsupported' starting with December 3rd:
actions/runner-images#10721
  • Loading branch information
kinke committed Nov 13, 2024
1 parent a7c85ec commit 5da688f
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 22 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ jobs:
# os: macos-13
# host_dmd: dmd
# coverage: true
- job_name: macOS 12 x64, DMD (bootstrap)
os: macos-12
- job_name: macOS 13 x64, DMD (bootstrap)
os: macos-13
# de-facto bootstrap version on OSX
# See: https://github.com/dlang/dmd/pull/13890
host_dmd: dmd-2.099.1
Expand Down
28 changes: 14 additions & 14 deletions .github/workflows/runnable_cxx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ jobs:
# very few PRs actually benefit from this.
fail-fast: false
matrix:
os: [ macOS-12, ubuntu-20.04, windows-2019 ]
os: [ macos-13, ubuntu-20.04, windows-2019 ]

target: [
# Versions of clang earlier than 11 are not available on 20.04, but are on macOS-12
# Versions of clang earlier than 11 are not available on 20.04, but are on macOS 13
clang-13.0.0, clang-12.0.0, clang-11.0.0, clang-10.0.0, clang-9.0.0, clang-8.0.0,
# For g++, we test the oldest compiler on Ubuntu 20.04, which is GCC-9
g++-11, g++-10, g++-9,
Expand All @@ -81,13 +81,13 @@ jobs:
- { os: ubuntu-20.04, target: msvc-2015 }
- { os: ubuntu-20.04, target: msvc-2013 }
# OSX only supports clang
- { os: macOS-12, target: g++-11 }
- { os: macOS-12, target: g++-10 }
- { os: macOS-12, target: g++-9 }
- { os: macOS-12, target: msvc-2019 }
- { os: macOS-12, target: msvc-2017 }
- { os: macOS-12, target: msvc-2015 }
- { os: macOS-12, target: msvc-2013 }
- { os: macos-13, target: g++-11 }
- { os: macos-13, target: g++-10 }
- { os: macos-13, target: g++-9 }
- { os: macos-13, target: msvc-2019 }
- { os: macos-13, target: msvc-2017 }
- { os: macos-13, target: msvc-2015 }
- { os: macos-13, target: msvc-2013 }
# We don't test g++ on Windows as DMD only mangles for MSVC
- { os: windows-2019, target: g++-11 }
- { os: windows-2019, target: g++-10 }
Expand Down Expand Up @@ -126,13 +126,13 @@ jobs:
- { target: g++-9, compiler: g++, cxx-version: 9.4.0, major: 9 }
# Platform boilerplate
- { os: ubuntu-20.04, arch: x86_64-linux-gnu-ubuntu-20.04 }
- { os: macOS-12, arch: x86_64-apple-darwin }
- { os: macos-13, arch: x86_64-apple-darwin }
# Clang 9.0.0 have a different arch for OSX
- { os: macOS-12, target: clang-9.0.0, arch: x86_64-darwin-apple }
- { os: macos-13, target: clang-9.0.0, arch: x86_64-darwin-apple }
# Those targets will generate artifacts that can be used by other testers
- { storeArtifacts: false }
- { os: ubuntu-20.04, target: g++-9, storeArtifacts: true }
- { os: macOS-12, target: clang-9.0.0, storeArtifacts: true }
- { os: macos-13, target: clang-9.0.0, storeArtifacts: true }
#- { os: windows-2019, target: msvc-2019, storeArtifacts: true }

# We're using the latest available images at the time of this commit.
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
# On OSX, the system header are installed via `xcode-select` and not distributed with clang
# Since some part of the testsuite rely on CC and CXX being only a binary (not a command),
# and config files where only introduced from 6.0.0, use a wrapper script.
if [ "${{ matrix.os }}" == "macOS-12" ]; then
if [ "${{ matrix.os }}" == "macos-13" ]; then
# Note: heredoc shouldn't be indented
cat << 'EOF' > ${TMP_CC}-wrapper
#!/bin/bash
Expand All @@ -231,7 +231,7 @@ jobs:
if: matrix.compiler == 'clang' && runner.os != 'Windows'
run: |
TMP_CC='${{ github.workspace }}/clang+llvm-${{ matrix.cxx-version }}-${{ matrix.arch }}/bin/clang'
if [ "${{ matrix.os }}" == "macOS-12" ]; then
if [ "${{ matrix.os }}" == "macos-13" ]; then
echo "CC=${TMP_CC}-wrapper" >> $GITHUB_ENV
echo "CXX=${TMP_CC}++-wrapper" >> $GITHUB_ENV
echo "SDKROOT=$(xcrun --show-sdk-path)" >> $GITHUB_ENV
Expand Down
12 changes: 6 additions & 6 deletions ci/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,12 @@ The auto tester tests DMD on various Posix platforms.
**Config**: [azure-pipelines.yml](https://github.com/dlang/dmd/blob/master/.github/workflows/runnable_cxx.yml)

**Checks**:
- C++ interop tests / Run (macOS-12, clang-13.0.0)
- C++ interop tests / Run (macOS-12, clang-12.0.0)
- C++ interop tests / Run (macOS-12, clang-11.0.0)
- C++ interop tests / Run (macOS-12, clang-10.0.0)
- C++ interop tests / Run (macOS-12, clang-9.0.0)
- C++ interop tests / Run (macOS-12, clang-8.0.0)
- C++ interop tests / Run (macos-13, clang-13.0.0)
- C++ interop tests / Run (macos-13, clang-12.0.0)
- C++ interop tests / Run (macos-13, clang-11.0.0)
- C++ interop tests / Run (macos-13, clang-10.0.0)
- C++ interop tests / Run (macos-13, clang-9.0.0)
- C++ interop tests / Run (macos-13, clang-8.0.0)
- C++ interop tests / Run (ubuntu-20.04, clang-13.0.0)
- C++ interop tests / Run (ubuntu-20.04, clang-12.0.0)
- C++ interop tests / Run (ubuntu-20.04, clang-11.0.0)
Expand Down

0 comments on commit 5da688f

Please sign in to comment.