Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the SC Enum aliases #14405

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Conversation

benjones
Copy link
Contributor

@benjones benjones commented Sep 1, 2022

Follow up to #14399
I removed the first ~5 of the enum aliases here and the diff was big enough that I figured I'd spread it across a couple of PRs. I also replaced entire switch/case blocks using the ones I removed, and other easily visible nearby uses of SCxxx enums.

@benjones
Copy link
Contributor Author

benjones commented Sep 2, 2022

@dlang-bot ??

@benjones benjones marked this pull request as draft September 2, 2022 15:26
@benjones benjones marked this pull request as ready for review September 2, 2022 15:26
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14405"

@benjones
Copy link
Contributor Author

benjones commented Sep 2, 2022

@dkorpel looks like the bot didn't assign reviewers, but since this is followup to your PR, you're probably the right person to look.

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You might want to do all of them at once and add the resulting commit to the git blame ignore revs list.

@benjones
Copy link
Contributor Author

benjones commented Sep 3, 2022

Looks good. You might want to do all of them at once and add the resulting commit to the git blame ignore revs list.

I removed the rest of the aliases in a second commit. I can squash them if you want. It doesn't look like there's a blame ignore revs file yet, should I add one to the root of the repo?

@thewilsonator
Copy link
Contributor

I can squash them if you want.

Yes please.

should I add one to the root of the repo?

Yes.

@benjones
Copy link
Contributor Author

benjones commented Sep 6, 2022

@thewilsonator Done

@benjones benjones changed the title remove some of the SC Enum aliases remove the SC Enum aliases Sep 6, 2022
@benjones
Copy link
Contributor Author

benjones commented Sep 9, 2022

@RazvanN7 bump

@thewilsonator thewilsonator merged commit c634c41 into dlang:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants