-
-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the SC Enum aliases #14405
remove the SC Enum aliases #14405
Conversation
@dlang-bot ?? |
Thanks for your pull request and interest in making D better, @benjones! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14405" |
2db0b5a
to
0604517
Compare
@dkorpel looks like the bot didn't assign reviewers, but since this is followup to your PR, you're probably the right person to look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You might want to do all of them at once and add the resulting commit to the git blame ignore revs list.
I removed the rest of the aliases in a second commit. I can squash them if you want. It doesn't look like there's a blame ignore revs file yet, should I add one to the root of the repo? |
Yes please.
Yes. |
292a251
to
a48cdda
Compare
@thewilsonator Done |
@RazvanN7 bump |
Follow up to #14399
I removed the first ~5 of the enum aliases here and the diff was big enough that I figured I'd spread it across a couple of PRs. I also replaced entire switch/case blocks using the ones I removed, and other easily visible nearby uses of SCxxx enums.