Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow qualified types in base class list #16882

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Bolpat
Copy link
Contributor

@Bolpat Bolpat commented Sep 26, 2024

Currently, it is allowed that a base class is a qualified type.

class C : const(Object) { }
auto obj = new class const(Object) { };

The qualifier is ignored. For that reason, this change makes it a parse error, so no code fools a reader into thinking the const does something. Semantics are unaffected, i.e. if a typeof type is used which ends up being a qualified class type, the unqualified version of that class type remains a base class (no error).

The assumption of this PR is that no-one actually has qualified base classes in their code base (because the qualifier does nothing but mislead the reader).

It is in the interest of the Primary Type Syntax DIP and possibly future tuple DIPs to avoid parsing ambiguities. This can be done by requiring the base class list to be lexically comprised of new-terminology basic types. Refer to the accompanying spec PR for details.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Bolpat! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16882"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this fix an issue? if so please retitle the commit message to fix it, otherwise please add a changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants