Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bugzilla 24848 - bad parser diagnostic for a partial MulExp #17055

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Nov 8, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24848 minor bad parser diagnostic for a partial MulExp

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17055"

@ntrel
Copy link
Contributor Author

ntrel commented Nov 8, 2024

I don't know why some tests for fail_compilation/traits_alone.d are passing but some failing:

-fail_compilation/traits_alone.d(11): Error: no identifier for declarator `__error`
+fail_compilation/traits_alone.d(11): Error: no identifier for declarator `_error_`

@ntrel ntrel marked this pull request as ready for review November 8, 2024 14:10
@ntrel
Copy link
Contributor Author

ntrel commented Nov 8, 2024

OK, seems to be just an unrelated error now:

./generated/windows/release/64/loadlibwin.exe 
D:\a\1\s\druntime\test\shared\src\linkDR.c : fatal error C1083: Cannot open compiler generated file: 'D:\a\1\s\druntime\test\shared\generated\windows\release\64.obj': Permission denied
make[2]: *** [../common.mak:113: generated/windows/release/64/linkDR.exe] Error 1

@dlang-bot dlang-bot merged commit e17cc3a into dlang:master Nov 10, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants