Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): align errorKindToString with SARIF level values #17058

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

royalpinto007
Copy link
Contributor

This PR introduces modifications to the errorKindToString function, aligning it with the SARIF specification for the level property in result objects (SARIF §3.27.10). The function now returns SARIF-compatible severity levels based on the ErrorKind values, facilitating accurate reporting in SARIF format.

Validated the output- SARIF Validator

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @royalpinto007! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17058"

@dlang-bot dlang-bot merged commit 33cd3b3 into dlang:master Nov 12, 2024
41 checks passed
@royalpinto007 royalpinto007 deleted the sarif-errorkind branch November 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants