Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 24855 - VRP fails to prevent overflow after division #17060

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Nov 12, 2024

Once again (#7317), graciously copying @tgehr's homework from https://github.com/tgehr/d-compiler/blob/master/vrange.d

@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 12, 2024

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24855 minor VRP fails to prevent overflow after division

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#17060"

@dlang-bot dlang-bot merged commit f6115f0 into dlang:master Nov 13, 2024
41 checks passed
@dkorpel dkorpel deleted the vrp-division branch November 13, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants