Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

std::optional #2780

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

std::optional #2780

wants to merge 3 commits into from

Conversation

TurkeyMan
Copy link
Contributor

The DMD union problem is fixed, this might get closer now...

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 31, 2019

Thanks for your pull request and interest in making D better, @TurkeyMan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + druntime#2780"

@TurkeyMan
Copy link
Contributor Author

Still blocked on https://issues.dlang.org/show_bug.cgi?id=19902
... which is a pretty bad regression!

@Laeeth
Copy link
Contributor

Laeeth commented Dec 23, 2019

@TurkeyMan with @adamdruppe splitting the traits into two PRs, is this now no longer blocked?

@12345swordy
Copy link
Contributor

ping @TurkeyMan

@TurkeyMan
Copy link
Contributor Author

This may be able to move forward now. I'll poke at it when I get a few minutes.

@RazvanN7
Copy link
Contributor

@TurkeyMan is this ready for review?

@dlang-bot dlang-bot removed the stalled label Apr 28, 2022
@dlang-bot dlang-bot removed the Needs Rebase needs a `git rebase` performed label May 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants