Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Issue 23157 - undefined reference to `__cmsg_nxthdr' on Alpine Li… #3830

Open
wants to merge 1 commit into
base: stable
Choose a base branch
from

Conversation

tom-tan
Copy link
Contributor

@tom-tan tom-tan commented Jun 4, 2022

…nux (musl libc)

The current definition of CMSG_NXTHDR uses __cmsg_nxthdr internally but __cmsg_nxthdr is not provided on Alpine Linux (musl libc).
This request fixes the issue 23157 by fixing the definiiton of CMSG_NXTHDR.

Here is a corresponding definition in musl libc header: https://git.musl-libc.org/cgit/musl/tree/include/sys/socket.h#n357

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 4, 2022

Thanks for your pull request and interest in making D better, @tom-tan! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
23157 regression undefined reference to `__cmsg_nxthdr' on Alpine Linux (musl libc)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + druntime#3830"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Jun 4, 2022
@tom-tan tom-tan force-pushed the fix-CMSG_NXTHDR-for-muslc branch from 3e4cf77 to 210d4c8 Compare June 4, 2022 07:45
@tom-tan tom-tan changed the base branch from master to stable June 4, 2022 07:46
Copy link
Member

@ljmf00 ljmf00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@dkorpel
Copy link
Contributor

dkorpel commented Jun 5, 2022

Can you please rebase this to restart the CI?

…nux (musl libc)

Make __CMSG_* and __MHDR_END private
@tom-tan tom-tan force-pushed the fix-CMSG_NXTHDR-for-muslc branch from b0ed0a0 to 7cac81e Compare June 5, 2022 10:44
@ljmf00
Copy link
Member

ljmf00 commented Jun 6, 2022

Buildkite succeeded now, but FreeBSD still has heisenbugs. Seems unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Fix Include reference to corresponding bugzilla issue stable-stalled System Headers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants