Use latest version of MongoDB API for v5.1+ compatibility #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebFreak001
requested changes
Jun 25, 2023
|
Updated with review, definitely better, thanks! |
Geod24
force-pushed
the
update-mongodb
branch
2 times, most recently
from
7bbb97e
to
7074d1a
Compare
|
Added a few more places I originally missed, should be all good now. |
WebFreak001
reviewed
Jun 26, 2023
source/dubregistry/dbcontroller.d
Outdated
| m_packages.ensureIndex([tuple("stats.score", 1)]); | ||
| m_downloads.ensureIndex([tuple("package", 1), tuple("version", 1)]); | ||
| IndexOptions opt; | ||
| opt.unique = true; |
There was a problem hiding this comment.
want to fix the mixed tabs and spaces here? otherwise LGTM
|
Okay this needs a new version of Vibe.d to merge, will look into it today. |
|
you get my approval after dependency bump then |
|
@Geod24 got new version released yet? |
|
thanks for version bump @s-ludwig |
WebFreak001
approved these changes
Aug 14, 2023
WebFreak001
force-pushed
the
update-mongodb
branch
from
bc74711
to
770dead
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff is pretty simple. Tested locally with MongoDB v6.0.6 on Ubuntu 22.04.
Needs a new release of Vibe.d to work.