Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Remove obsolete support for OMF/DMC/Optlink toolchain #578

Merged
merged 2 commits into from
May 26, 2024

Conversation

kinke
Copy link
Contributor

@kinke kinke commented May 25, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@kinke
Copy link
Contributor Author

kinke commented May 26, 2024

I've noticed that the changes to the create_dmd_release/extras overlay surprisingly aren't applied for the CI artifacts. The problem is that build_all.d clones all repos, incl. the installer repo itself, and uses that tree for the extras (looks like that's the only problematic subtree). For PRs like this from a forked repo, it uses the master branch of installer and its extras. It's only after merging that CI uses the new extras, and might break. FYI @ibuclaw

As a workaround, one can presumably push the branch to the upstream remote directly.

@kinke kinke marked this pull request as ready for review May 26, 2024 02:14
@thewilsonator thewilsonator merged commit d84001d into dlang:master May 26, 2024
16 checks passed
@kinke kinke deleted the rm_omf branch May 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants