Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Rename Windows installer artifacts to dmd-<branch>.exe #587

Merged

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jul 19, 2024

Don't use the DMD VERSION file, currently leading to names like dmd-v2.110.0-beta.1.exe, which accumulate for the nightly release: https://github.com/dlang/dmd/releases/tag/nightly

Switch to dmd-master.exe, similar to the other artifact names.

Don't use the DMD VERSION file, currently leading to names like
`dmd-v2.110.0-beta.1.exe`, which accumulate for the nightly release:
https://github.com/dlang/dmd/releases/tag/nightly

Switch to `dmd-master.exe`, similar to the other artifact names.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@thewilsonator thewilsonator merged commit 2713e4e into dlang:master Jul 21, 2024
14 checks passed
@kinke kinke deleted the rename_windows_installer_artifacts branch July 21, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants