Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for -preview=in and targets preferring by-ref for real #7687

Merged
merged 1 commit into from
Nov 1, 2020

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Oct 31, 2020

Code compiled with -preview=in is currently supposed to link successfully against druntime/Phobos compiled without -preview=in.

There were still a few places where -preview=in makes a difference for existing in params; convert them to const [scope], analogous to PR #7593.

Code compiled with -preview=in is currently supposed to link
successfully against druntime/Phobos compiled without -preview=in.

There were still a few places where -preview=in makes a difference for
existing `in` params; convert them to `const [scope]`, analogous to
PR dlang#7593.
@kinke kinke requested a review from andralex as a code owner October 31, 2020 22:35
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7687"

@dlang-bot dlang-bot merged commit 2bcc237 into dlang:master Nov 1, 2020
@kinke kinke deleted the preview_in branch November 1, 2020 01:08
@Geod24
Copy link
Member

Geod24 commented Nov 1, 2020

@kinke : Does that mean that LDC v1.24 is not compatible with -preview=in for those functions ?
As I assume it contains dlang/dmd#11828 but not this.

@kinke
Copy link
Contributor Author

kinke commented Nov 1, 2020

I guess so, just like DMD 2.094[.1] isn't for targets with by-ref real (Win64, 32-bit x86 IIRC). But LDC uses double-precision real for MSVC targets, so isn't as affected as DMD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants