Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove digger setup and use the compiler from Travis #298

Merged
merged 1 commit into from
Jan 26, 2018

Conversation

wilzbach
Copy link
Member

Digger was added to be able to test tools with the latest DMD.
So Digger builds the latest dmd, druntime and phobos and we have enabled a daily cron here that checks every day that things are still working.
However, now that we have the Project Tester we can simply add dlang/tools to it and thus be on the safe side as the testsuite is now run on every PR.

The respective dlang/ci PR is: dlang/ci#130

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach added the PR.Blocked A PR blocker by another issue / PR, external to the PR (as opposed to WIP) label Jan 24, 2018
@WebDrake
Copy link
Contributor

I think it might be a good idea to tie down test requirements of #297 before making changes like this. Unless there are other reasons motivating these changes I would suggest putting them on hold (likewise the CI PR).

@wilzbach
Copy link
Member Author

I think it might be a good idea to tie down test requirements of #297 before making changes like this.

Fair enough - it's not passing Travis anyways at the moment.

I would suggest putting them on hold (likewise the CI PR).

I don't agree about the CI PR. It's a requirement that dlang/tools is always buildable with latest, greatest master. This requirement will never change. All dlang/ci does is to execute the travis.sh, so we are pretty flexible, but if changes are needed this can be easily overwritten to manually execute the Makefile with dmd only.
OTOH this hasn't been done for a couple of months, so waiting a few more days doesn't hurt and it isn't a pressing subject.

Unless there are other reasons motivating these changes

Well, the dlang/ci PR should have been made ages ago - it's just that nobody thought about it.

@WebDrake
Copy link
Contributor

I don't agree about the CI PR. It's a requirement that dlang/tools is always buildable with latest, greatest master.

Yup, makes sense. I hadn't looked at it properly and misunderstood the intention (I'd assumed it was a PR to make this one possible).

@MartinNowak
Copy link
Member

Use dmd-nightly on Travis-CI if you want to test compat of rdmd changes against a recent master dmd, no reason to rebuild binaries.

- test dmd-nightly instead
@MartinNowak MartinNowak force-pushed the remove-digger branch 2 times, most recently from 3fd0144 to 3d7ee66 Compare January 25, 2018 11:48
@MartinNowak MartinNowak merged commit 5bd4244 into dlang:master Jan 26, 2018
@wilzbach wilzbach deleted the remove-digger branch January 26, 2018 20:21

dmd --version
rdmd --help | head -n 1
dub --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these 3 lines removed? They don't seem related to the rest of the PR and I'd have thought it's convenient to have dmd, rdmd and dub report their versions in the build logs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are automatically added by our Travis integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR.Blocked A PR blocker by another issue / PR, external to the PR (as opposed to WIP)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants