-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove digger setup and use the compiler from Travis #298
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
I think it might be a good idea to tie down test requirements of #297 before making changes like this. Unless there are other reasons motivating these changes I would suggest putting them on hold (likewise the CI PR). |
Fair enough - it's not passing Travis anyways at the moment.
I don't agree about the CI PR. It's a requirement that
Well, the |
Yup, makes sense. I hadn't looked at it properly and misunderstood the intention (I'd assumed it was a PR to make this one possible). |
Use dmd-nightly on Travis-CI if you want to test compat of rdmd changes against a recent master dmd, no reason to rebuild binaries. |
- test dmd-nightly instead
3fd0144
to
3d7ee66
Compare
|
||
dmd --version | ||
rdmd --help | head -n 1 | ||
dub --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these 3 lines removed? They don't seem related to the rest of the PR and I'd have thought it's convenient to have dmd
, rdmd
and dub
report their versions in the build logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are automatically added by our Travis integration.
Digger was added to be able to test
tools
with the latest DMD.So Digger builds the latest
dmd
,druntime
andphobos
and we have enabled a daily cron here that checks every day that things are still working.However, now that we have the Project Tester we can simply add
dlang/tools
to it and thus be on the safe side as the testsuite is now run on every PR.The respective dlang/ci PR is: dlang/ci#130