Adding customer storage recalculator and entity counter recalculator functions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
changed the title
donaldgray
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Couple of comments but other than that LGTM.
Edit
Is it worth squashing a few of the commits for a cleaner commit history? E.g.
- fixing yaml
- fixing pip install
- attempting dependencies zip
- changing to use ${{NOW}}
- changing to use $(NOW)
- changing to use ${{ env.NOW }}
- removing colons
- changing zip package
- removing /packages
into - "fixing various issues with zip" (bad naming but hopefully you get what I mean!)
JackLewis-digirati
force-pushed
the
feature/customer-storage-recalculator
branch
from
17d2d93
to
b81dace
Compare
JackLewis-digirati
deleted the
feature/customer-storage-recalculator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in docker based python images that can be run with AWS lambda