Add ability to PUT IIIF collections #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
changed the title
# Conflicts: # src/IIIFPresentation/API.Tests/Integration/ModifyCollectionTests.cs # src/IIIFPresentation/API/Converters/CollectionConverter.cs # src/IIIFPresentation/API/Features/Storage/Helpers/ErrorHelper.cs # src/IIIFPresentation/API/Features/Storage/Requests/CreateCollection.cs # src/IIIFPresentation/API/Features/Storage/Requests/UpsertCollection.cs # src/IIIFPresentation/API/Features/Storage/StorageController.cs # src/IIIFPresentation/API/Features/Storage/Validators/PresentationCollectionValidator.cs # src/IIIFPresentation/API/Program.cs # src/IIIFPresentation/Core/IIIF/IIIFResponseX.cs # src/IIIFPresentation/Models/API/General/ModifyCollectionType.cs
JackLewis-digirati
requested review from
donaldgray,
p-kaczynski,
griffri and
tomcrane
donaldgray
reviewed
Oct 24, 2024
src/IIIFPresentation/API.Tests/Converters/CollectionConverterTests.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/API.Tests/Integration/ModifyCollectionTests.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/API.Tests/Integration/ModifyManifestTests.cs
Outdated
Show resolved
Hide resolved
griffri
reviewed
Oct 24, 2024
# Conflicts: # src/IIIFPresentation/API.Tests/Integration/ModifyManifestTests.cs # src/IIIFPresentation/Core/IIIF/IIIFResponseX.cs
donaldgray
approved these changes
Oct 24, 2024
…respond with iiif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54
This PR allows
PUTto be used to update IIIF collections. Additionally, there is a change to howPOSTandPUTeport success to provide both the additional fields add to an S3 collection as well as the fixed fields added from the presentation collection.I.E.: if a
homepagedirective is added to the JSON, it will be added to the response, whereas previously the only way to see this field was to callGEThierarchicalimplementation details