Fix bug preventing deeper nested hierach collection creation #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119. Issue was how slug was concatenated, slash was missing meaning all path segments were concatenated. Using examples from ticket:
/nest_test_a- resulted in looking for parent with slug""(root)/nest_test_a/nest_test_b- resulted in looking for parent with slug"nest_test_a"(created above)./nest_test_a/nest_test_b/nest_test_c- resulted in looking for parent with slug"nest_test_bnest_test_c"as segments were joined withstring.Emptywhich was not found. Fix is to concatenate elements with"/"so we now look for"nest_test_b/nest_test_c"Also added missing tests for
RetrieveHierarchy