Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure matching 'modified' and 'creation' collection values on create #40

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Sep 23, 2024

Resolves #39

This PR fixes a minor bug that caused a slight difference between the created and modified timestamps on a newly created collection, caused by calling DateTime.UtcNow twice.

@griffri griffri force-pushed the fix/new_collection_timestamps branch from 3f8add6 to af14782 Compare September 23, 2024 09:27
@griffri griffri changed the title Apply matching 'modified' and 'creation' collection values on create Ensure matching 'modified' and 'creation' collection values on create Sep 23, 2024
@JackLewis-digirati
Copy link
Collaborator

Is it worth modifying a test to check these values are the same on POST?

…he `created` and `modified` values are the same
@griffri griffri force-pushed the fix/new_collection_timestamps branch from 72cd932 to 134d39d Compare September 23, 2024 10:44
@griffri griffri merged commit 3b933d7 into main Sep 23, 2024
3 checks passed
@griffri griffri deleted the fix/new_collection_timestamps branch September 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

created and modified timestamps on a new storage collection are different
2 participants