Thumbnail can't handle IIIF style thumbnail on POST #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
force-pushed
the
fix/thumbnailExpectsExternalResource
branch
from
ec496d8
to
7188705
Compare
JackLewis-digirati
force-pushed
the
fix/thumbnailExpectsExternalResource
branch
from
7949d41
to
dc4bfe5
Compare
donaldgray
reviewed
Oct 14, 2024
src/IIIFPresentation/API/Features/Storage/Requests/CreateCollection.cs
Outdated
Show resolved
Hide resolved
src/IIIFPresentation/API/Features/Storage/Requests/CreateCollection.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
changed the title
griffri
reviewed
Oct 16, 2024
src/IIIFPresentation/API/Features/Storage/Requests/CreateCollection.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
force-pushed
the
fix/thumbnailExpectsExternalResource
branch
from
5d82715
to
0f290ce
Compare
griffri
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #57
This PR allows thumbnails to be correctly converted between
ExternalResourceandstringwhen using POST on a IIIF collection, via acollections