Handle 404 when fetching PDF + bump dependencies #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes were originally to better handle errors. There were log entries about corrupt PDFs but it was due to 404's not being correctly handled so the resulting file was an HTML blob - fix was to add
download_request.raise_for_status()and abort processing if encountered. As part of implementing + testing I bumped a few python dependencies.Also resolved #2, but rather forking pdf-alto lib I added the generated binary to
/depsfolder. Originally a multi stage Docker build built this and copied it over but it took a long time. This change simplifies + speeds up the build at the cost of having a large binary in repo.Resolved #3 too as part of update work, this pins the Localstack Dockerfile to a known version and uses latest init.d folder format.