Disable pin checks if no platform support #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms don't define this macro, so we can define it for ourselves.
The library won't compile on Arduino platforms that do not define the `NOT_AN_INTERRUPT` macro. This macro is used by the library to evaluate whether a pin is supported for interrupts. The previous fix (e7e5845) defines this macro if it's missing, with the assumption that all pins on the platform support interrupts. That didn't solve the issue with the renesas platform (#28) however, as the `digitalPinToInterrupt()` function is a passthrough and not a compile-time constant. That fails the `static_assert()` check. Instead, this patch adds a bypass. If `NOT_AN_INTERRUPT` is not defined, all code that uses the `digitalPinToInterrupt()` function and the `NOT_AN_INTERRUPT` flag is disabled. There won't be any compile-time or run-time checks for whether the pin is supported or not, but there's nothing we can do about that if the platform doesn't support the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a platform doesn't support checking if a given pin supports interrupts (using the
NOT_AN_INTERRUPTdefine), disable the code snippets which check if a pin supports interrupts. Since we cannot tell which pins support interrupts, this also disables the pin-change interrupt feature on those platforms.This should fix compilation issues on some platforms.
See issue #28 for reference.