Unused pin rework #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a value we control rather than the platform-specific define (which isn't really meant for this purpose anyways).
Treating all negative numbers as invalid pins, sanitized to UnusedPin on assignment.
Removing const from pin number members to allow copying, and changing argument names so that 'pin' is the prefix rather than the suffix in all cases. This should not affect any user code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way pins are handled internally with the library.
PinNumtype, rather thanuint8_t. This makes it more obvious what each argument expects and allows for changing all pin types together. ThePinNumtype is currentlyint16_t.NOT_A_PINreferences, which used the macro from the AVR core, have been replaced with a new constant,UnusedPin. TheNOT_A_PINmacro wasn't really meant for this usage, and this change makes the library more portable.UnusedPin.The end result is (hopefully) that pins which are unused are more robustly ignored, and the library is more portable.