-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use torch core instead of torchdata modules. #7609
Conversation
To trigger regression tests:
|
@frozenbugs wouldn't they remove these too? Since we want to be able to use later torch versions, if they remove these from core repo as well, we will have to go back to torchdata <0.8.0. I feel depending on torchdata might be a better choice. We can verify whether they plan to remove the datapipes from the core as that is my current understanding. |
@frozenbugs Andrew Kho, the lead torchdata developer said that the datapipes in torch.utils.data are most likely to be deprecated and removed as well. So #7604 seems to be the way to go for now. |
Currently we are rely on functional_datapipe from torch.data package as well, it could break us if they remove datapipe from core entirely. Also the torchdata module seems rely on torch.data for many of the modules, if they remove the code from torch core, how would the dependency look like? |
I asked that now. I asked if we pin torchdata<0.8.0, whether we can update to later torch versions. If we are lucky, maybe they will make a new 0.7.2 release that is compatible with future torch releases, maybe not. Worst case, we implement our own datapipes or consider if the new thing they have can replace datapipes for our use case. |
For reference: pytorch/data#1196 |
They said this: 0.8.0 will still have datapipes, but generally we won’t be able to continuously support all cross versioning so at some point it will probably break, and you’ll probably need to set up your package manager appropriately to try it out |
From the announcement, it seems that they haven't made the decision on remove datapipe from torch core. That says we can merge this PR first and get rid of |
Description
Checklist
Please feel free to remove inapplicable items for your PR.
Changes